-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getScopedElementsTemplate to publish #2707
base: master
Are you sure you want to change the base?
Conversation
|
|
Can you please share some extended usage of this so I can understand what this is unlocking? |
Of course, if we use fixtureSync with scoped elements like this:
fixtureSync call litFixtureSync without
|
Why do I keep receiving messages from GitHub’s
Jamie
…On Wed, Sep 27, 2023 at 4:51 PM Rousseau Julien ***@***.***> wrote:
Of course, if we use fixtureSync with scoped elements like this:
const el = fixtureSync<DtContractHeader>(fixtureData, {
scopedElements: {
'dt-contract-header': DtContractHeader,
},
});
Then we have this error:
[image: image]
<https://user-images.githubusercontent.com/3296671/271112141-91a2bb15-5e70-4ef4-9413-9a16cc0f1329.png>
fixtureSync call litFixtureSync without getScopedElementsTemplate.
export function litFixtureSync(template, options = {}, getScopedElementsTemplate) {
...
—
Reply to this email directly, view it on GitHub
<#2707 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP5YUCQQAUD644H5JSLYH4LX4SGTZANCNFSM6AAAAAA5JMEQRI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
4a03030
to
a7076a9
Compare
There are a bunch of tests that fail with this change. Please take a closer look so we can fully review this update. See: https://github.com/open-wc/open-wc/actions/runs/6434919239/job/17475126467?pr=2707 |
What I did
Added
getScopedElementsTemplate
to publish to use it with litFixtureSync function.