Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate output of make generate in a presubmit to make sure it is run #2734

Open
vivek-koppuru opened this issue Jul 15, 2022 · 0 comments
Open

Validate output of make generate in a presubmit to make sure it is run #2734

vivek-koppuru opened this issue Jul 15, 2022 · 0 comments

Comments

@vivek-koppuru
Copy link
Member

vivek-koppuru commented Jul 15, 2022 •
edited
Loading

Add a presubmit to validate output of make generate when creating the generated code in the api package. Right now, we just have a suggestion to remind the user to do this manually, but adding a presubmit ensures that code won't get merged unless this target is run.

eks-anywhere/pkg/api/v1alpha1/tinkerbelldatacenterconfig_types.go

Line 11 in f454a4a

// Important: Run "make generate" to regenerate code after modifying this file

eks-anywhere/Makefile

Lines 363 to 364 in f5a5804

generate: $(CONTROLLER_GEN) ## Generate zz_generated.deepcopy.go
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vivek-koppuru