Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk-cdk-toolkit-extract-jdbc: fix cursor-related bugs #44402

Closed
wants to merge 3 commits into from

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Aug 19, 2024

What

This PR fixes a few bugs related to cursor-based incremental syncs:

  1. The cursor's lower bound value needs to be included in the WHERE clause because the cursor column values may be not unique; right now we're facing data loss for example if the cursor column is of type DATE DEFAULT NOW() and rows get inserted after a daily sync but on the same day.
  2. In source-oracle, empty tables incorrectly trigger a ConfigErrorException because SELECT MAX(...) will return NULL.

How

Review guide

Commit by commit.

User Impact

None.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Aug 19, 2024 5:37pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 19, 2024
@postamar postamar marked this pull request as ready for review August 19, 2024 19:36
@postamar postamar requested a review from a team August 19, 2024 19:43
@postamar postamar closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants