Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch in Arguments #5

Open
gvermaredrock opened this issue Jun 12, 2020 · 6 comments
Open

Mismatch in Arguments #5

gvermaredrock opened this issue Jun 12, 2020 · 6 comments
Assignees
@akanyaani
Labels
bug Something isn't working

Comments

@gvermaredrock
Copy link

In Line 180 of gpt2_model, we define the function as:
def distributed_train_step(self,inputs, targets,step,grad_clip=True, clip_value=1.0):

But In line 229, we instantiate it as:
train_loss = self.distributed_train_step(inputs, step)

The targets variable / argument is missing.
@rfebbo
Copy link

rfebbo commented Jul 8, 2020

Is there a fix for this?

@gvermaredrock
Copy link
Author

Hi, can you please tell if this will be fixed? Thanks

@akanyaani
Copy link
Owner

akanyaani commented Sep 16, 2020 via email

@gvermaredrock
Copy link
Author

Thanks Man, really looking forward to it. :)

@akanyaani akanyaani self-assigned this Sep 19, 2020
@akanyaani akanyaani added the bug Something isn't working label Sep 19, 2020
@akanyaani
Copy link
Owner

Hi @rfebbo, @gvermaredrock ,
I have fixed the issue, please let me you find another issue.

@nasheedyasin
Copy link

great, thanks man. please close the bug then as it is misleading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akanyaani akanyaani

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rfebbo @akanyaani @gvermaredrock @nasheedyasin