Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs/index page to include same information as private beta #527

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Update docs/index page to include same information as private beta #527

merged 2 commits into from
Jun 28, 2018

Conversation

NickColley
Copy link
Contributor

Also fixes some alignment issues

@NickColley NickColley added this to the 7.0.0 (Stable) milestone Jun 28, 2018
@joelanman
Copy link
Contributor

nice but I think this is still different from beta - see https://github.com/alphagov/govuk-prototype-kit-private-beta/blob/master/docs/views/index.html#L43-L69

@NickColley
Copy link
Contributor Author

@joelanman each element has a margin-top that can be removed if there's a margin-bottom on the previous element?

@NickColley
Copy link
Contributor Author

@joelanman updated

joelanman
joelanman approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks

@NickColley NickColley merged commit 208821d into master Jun 28, 2018
@NickColley NickColley deleted the fix-spacing-in-messaging branch June 28, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanman joelanman joelanman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NickColley @joelanman