Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other Windows issues #43

Closed
alphapapa opened this issue Jul 19, 2018 · 0 comments
Closed

Other Windows issues #43

alphapapa opened this issue Jul 19, 2018 · 0 comments
Assignees
@alphapapa

Comments

@alphapapa
Copy link
Owner

https://www.reddit.com/r/emacs/comments/8y49hv/magittodos_show_source_files_todos_and_fixmes_etc/e2lr37n/

In the latest version, testing for the regular expressions pops up a webbrowser on Windows, and the test always fails. This might not be specific to Windows, depending on the help.format setting of git.

An other way to test it would be passing in an invalid parameter, so the test command could be git grep --magit-todos-test-for-pgrep instead of git grep --help. This never starts an external help command and returns the information on stdout.

Also, a check to see if nice is available on the system would be nice (pun..), since it is not available on Windows.

Keep up the great work, this is really useful!
@alphapapa alphapapa self-assigned this Jul 31, 2018
@Kungsgeten Kungsgeten mentioned this issue Dec 10, 2018
Closed
@roadrunner1776 roadrunner1776 mentioned this issue Apr 1, 2019
Closed
roadrunner1776 added a commit to roadrunner1776/magit-todos that referenced this issue Apr 3, 2019
@roadrunner1776
Issue alphapapa#43 fix
e324004
Pireax added a commit to Pireax/magit-todos that referenced this issue May 18, 2019
@Pireax
Fix alphapapa#43
05085e2
@Pireax Pireax mentioned this issue May 18, 2019
Closed
Pireax added a commit to Pireax/magit-todos that referenced this issue May 18, 2019
@Pireax
Fix alphapapa#43
b29d8d3
@seagle0128 seagle0128 mentioned this issue Dec 4, 2019
Closed
seagle0128 added a commit to seagle0128/.emacs.d that referenced this issue Dec 4, 2019
@seagle0128
Disable "git-grep(1)" Popup Browser Tab on Windows.
c1391de 
Diable magit-todos.
Fix #137, #84.
Refer to alphapapa/magit-todos#43.
seagle0128 added a commit to seagle0128/.emacs.d that referenced this issue Dec 31, 2019
@seagle0128
Update accordding to fixing magit-todos.
8a55bb6 
See alphapapa/magit-todos#43.
Refer to #137, #84.
alphapapa added a commit that referenced this issue Jan 8, 2020
@alphapapa
Fix: Don't use --help when testing git-grep command
c14bfa6 
Fixes #43.  Closes #73, #79.

Thanks to @roadrunner1776, @Pireax, @Kungsgeten, @seagle0128,
@davidpgil.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #43 Pireax/magit-todos
1 participant
@alphapapa