-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airflow SFTPToGCSOperator sftp file exist check #41472
Comments
Is there an issue with using an |
The SFTP sensor will wait until the file is detected. This issue is to determine whether the task should fail if the file is not found. |
I see. In that case, I don't think it makes sense to have the task succeed if a file is not found. A 'success' would not have much meaning anymore besides that the task simply ran. The interpretation of 'success' would become ambiguous i.e. how can you tell if a file was indeed moved or not without having to further dig into the logs? In addition, it doesn't feel very 'airflow-like' since we would be overloading the operator with functionality that already exists through a sensor. I'm not sure what your DAG looks like, but perhaps you can use a |
I agree with your point, but this is an optional parameter. By default, it will fail the task if the file is not found. If the user sets the
The final task of my DAG is looking for a file, and the dag_run should not fail, though the file is not present. And I don't want to use the sensor to poke for a file. |
That's unfortunate you don't want to use a sensor for checking for file existence. If the sensor failed (i.e. file didn't exist after some time), you could have it At any rate, I think as long as you use the trigger rule |
Description
Currently, the operator fails if a file is not found on the SFTP server. To make this behavior more flexible, we could introduce a new parameter,
fail_on_sftp_file_not_exist
, allowing users to customize the operator's response in such scenarios. By setting this parameter, users can choose whether the operator should raise an error when a file is missing or simply log a message and continue processing.Use case/motivation
This enhancement would give users greater control over the operator's behaviour, particularly in environments where missing files are expected or where continued processing is preferred.
Related issues
A similar issue has been opened for the
SFTPToS3Operator
.Are you willing to submit a PR?
Code of Conduct
I agree to follow this project's Code of Conduct
PR
The text was updated successfully, but these errors were encountered: