Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dependency upgrades for 2.20.1 #1591

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

ppkarwasz
Copy link
Contributor

This PR adds the dependency bumps performed by Dependabot to the changelog of the next 2.x release.

@ppkarwasz ppkarwasz requested a review from vy July 21, 2023 19:53
@ppkarwasz ppkarwasz added this to the 2.20.1 milestone Jul 21, 2023
@vy
Copy link
Member

vy commented Jul 25, 2023

Could you place each update to a separate changelog entry file, please? If you stick to a certain naming convention in file names and descriptions, it would get formatted nicely.

Also please keep in mind that the whole idea of using separate changelog entry files is to avoid merge conflicts. One day 🤞 we can even make dependabot to create those files. Hence, squashing updates to a single entry is counter to the design principles of log4j-changelog.

@ppkarwasz ppkarwasz force-pushed the deps-2.20.1 branch 2 times, most recently from 93b5343 to 390fdb6 Compare August 7, 2023 18:21
@ppkarwasz
Copy link
Contributor Author

@vy,

I split all the updates into separate changelog entries. Looking at the result I see a problem with the way log4j-changelog classifies changes. I would say that in terms of importance we should sort sections as:

  • "Removed" (oops, something will break),
  • "Added" (yuppie, a new feature),
  • "Changed",
  • "Fixed",
  • dependencies should probably be a separate and last section, since they are the less important.

@ppkarwasz ppkarwasz merged commit a795b6f into apache:2.x Oct 5, 2023
4 checks passed
@ppkarwasz ppkarwasz deleted the deps-2.20.1 branch November 21, 2023 17:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants