Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open FileExtension accessors (#1365) #1683

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Open FileExtension accessors (#1365) #1683

merged 1 commit into from
Oct 11, 2023

Conversation

Karthi1711
Copy link
Contributor

#1365

Access modifier changed from default to public of FileExtension class in below api's

  1. createCompressAction()
  2. getExtension()
  3. length()

@karthi-gk-20146
createCompressAction(), getExtension(), length() in FileExtension api…
07bcb19 
…s access modifier changed from protected to public
@Karthi1711 Karthi1711 mentioned this pull request Aug 9, 2023
Closed
@vy vy changed the title Issue 1365: Access modifier changes of API's in FileExtension Open FileExtension accessors (#1365) Oct 11, 2023
@vy vy self-assigned this Oct 11, 2023
@vy
Copy link
Member

vy commented Oct 11, 2023

@Karthi1711, I am fine with these changes; except the length(). Let's keep the opened up methods to minimum: createCompressAction() and getExtension() are fine, but we don't need length(), which is accessible by getExtension().length() anyway.

I will

  1. merge the changes
  2. make length() package-private again
  3. add a changelog entry

@vy vy added api Affects the public API enhancement Additions or updates to features labels Oct 11, 2023
@vy vy merged commit 6bfeed0 into apache:2.x Oct 11, 2023
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Close FileExtension#length() accessor (#1365, #1683)
0aaab66
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Fix compilation errors in FileExtension (#1365, #1683)
2e8a548
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Add changelog entry (#1365, #1683)
80c37ae
vy pushed a commit that referenced this pull request Oct 11, 2023
@Karthi1711 @karthi-gk-20146 @vy
Open FileExtension accessors (#1365, #1683)
eae549b 
Co-authored-by: karthi-zt571 <karthi.gk@zohocorp.com>
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Close FileExtension#length() accessor (#1365, #1683)
3c27f2d
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Fix compilation errors in FileExtension (#1365, #1683)
c94787b
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Add changelog entry (#1365, #1683)
4965c09
@vy vy added this to the 2.21.0 milestone Oct 11, 2023
vy added a commit that referenced this pull request Oct 11, 2023
@vy
Bump FileExtension package @Version to indicate API changes (#1365,
5fd6eaf 
#1683)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vy vy

Labels
api Affects the public API enhancement Additions or updates to features
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Karthi1711 @vy @karthi-gk-20146