Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j-kubernetes in version 2.x #2412

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

ppkarwasz
Copy link
Contributor

@ppkarwasz ppkarwasz commented Mar 26, 2024

This is the 2.x equivalent of #2408

Due to differences in the lifecycle of Log4j Core and Kubernetes Client, we remove log4j-kubernetes from the 2.x release and redirect users to Fabric8's own kubernetes-log4j artifact introduced in fabric8io/kubernetes-client#5718.

The log4j-kubernetes lookup depends on:

  • the very stable StrLookup interface from Log4j Core,
  • the evolving set of Kubernetes metadata provided by Kubernetes Client.

Therefore it makes more sense to distribute the lookup together with Kubernetes Client.

Note: the Spring Cloud manual page has been synchronized with 3.x.

ppkarwasz added a commit that referenced this pull request Mar 26, 2024
Due to differences in the lifecycle of Log4j Core and Kubernetes Client,
we remove `log4j-kubernetes` from the 2.x release and redirect users to
Fabric8's own `kubernetes-log4j` artifact introduced in fabric8io/kubernetes-client#5718.

The `log4j-kubernetes` lookup depends on:

* the very stable `StrLookup` interface from Log4j Core,
* the evolving set of Kubernetes metadata provided by Kubernetes Client.

Therefore it makes more sense to distribute the lookup together with
Kubernetes Client.
@ppkarwasz ppkarwasz force-pushed the feature/remove-log4j-kubernetes-2.x branch from 0c839e7 to b31919f Compare March 27, 2024 15:52
@ppkarwasz ppkarwasz merged commit b31919f into 2.x Mar 27, 2024
5 of 6 checks passed
@ppkarwasz ppkarwasz deleted the feature/remove-log4j-kubernetes-2.x branch March 27, 2024 15:52
@ppkarwasz
Copy link
Contributor Author

Closes #2218.

@ppkarwasz ppkarwasz added this to the 2.24.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant