-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The core.Logger#setLevel method should work like #2282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we simply test that setting a new level on a "foo" logger changes the effective level on a "foo.bar" logger?
@@ -542,6 +542,7 @@ | |||
<plugin> | |||
<groupId>org.apache.rat</groupId> | |||
<artifactId>apache-rat-plugin</artifactId> | |||
<version>0.16.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should bump this in logging-parent
if necessary or even better in the ASF parent: apache/maven-apache-parent#193
BTW: you should also add a file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test too, please?
cb1f19f
to
5bf9bbd
Compare
I added tests but they fail. I can't tell if the issue is in main or the test itself... See |
Configurator#setLevel apache#2281
5bf9bbd
to
99c4e2f
Compare
TY @ppkarwasz ! |
The core.Logger#setLevel method should work like Configurator#setLevel #2281
@ppkarwasz
I'm not sure how to really test this from our 1.2 module but I did install a snapshot locally and tested it with my Apache Commons Logging branch here https://github.com/garydgregory/commons-logging/tree/log4j1-log42-api
The POM change to apache-rat-plugin was required for
mvn clean verify
to pass locally.