Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for 8 endpoints and fixed 3 of them #468

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

sse87
Copy link
Contributor

@sse87 sse87 commented Sep 24, 2018

New documentation for following endpoints:

  • /calendar
  • /carparks
  • /cinema
  • /declension
  • /golf
  • /isbolti
  • /isnic
  • /names

Fixed following endpoints:

  • /cinema Source html changed and theater page removed
  • /declension Source html attribute changed
  • /names $(this) not working in an arrow function`

Improved following endpoints:

  • /cinema Added theater metadata
  • /carparks Added opening hours
  • /names Added more options like get all names or get all declined names

Make docs for other endpoints more consistant.

Copy link
Member

@MiniGod MiniGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is a lot of really nice improvements! <3

endpoints/names/index.js Outdated Show resolved Hide resolved
endpoints/cinema/index.js Outdated Show resolved Hide resolved
endpoints/cinema/index.js Outdated Show resolved Hide resolved
@sse87 sse87 changed the title Adding docs for calendar and isnic Added docs for 8 endpoints and fixed 3 of them Sep 26, 2018
@sse87
Copy link
Contributor Author

sse87 commented Sep 27, 2018

I'm done adding new stuff to this PR, just fixes if you guys see anything. 😉

@sse87
Copy link
Contributor Author

sse87 commented Feb 22, 2019

So any change of more reviews? I'm still here for comments.

Copy link
Member

@MiniGod MiniGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, but doesn't really matter.

endpoints/names/index.js Outdated Show resolved Hide resolved
@sse87
Copy link
Contributor Author

sse87 commented Feb 25, 2019

Tests fails because cached test data (mock-data.json) has mismatch or invalid information.

All tests passes after I removed all island.is records from the file or total of 18 items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants