-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed SharedKernel : Clean.Architecture and Ardalis #737
Comments
Ah, yeah, that should probably be fixed. Thanks! |
This could well be my first Hacktoberfest issue👍 I would like to help on this. |
…ueFix: 1) Replaced Ardalis.SharedKernel with NimblePros.SharedKernel nuget package in Core project 2) Added Ardalis.SharedKernel nuget package in UseCases project as CQRS interfaces are only available in this package 3) Removed Ardalis.SharedKernel nuget package in Infrastructure project
Ok looking at this and the first sentence above I agree with (don't use Clean.Architecture.SharedKernel and Ardalis.SharedKernel) but I realize after reviewing the PR that I don't know about using So, if you want to adjust your PR to just use Ardalis.SharedKernel for everything that'd be great and I'll try to figure out my future plans for NimblePros.SharedKernel (if any). Thanks! |
Ok I figured it out. The That being said... All references to shared kernel in the sample should use the NimblePros.SharedKernel package and namespace. I'm in the process of doing major updates to the sample myself which will likely include updating the SharedKernel package version so we'll see how this merges in. |
when used as base for other projects, "NimblePros" is meant to be replaced with "Contoso" of each of the forked user projects. |
Right, exactly. Unfortunately it looks like I just did a Visual Studio Publish to create that Nuget package, so I'll need to do that again sometime soon so that it gets the latest updates that are in Ardalis.SharedKernel. It's on my backlog... |
In the latest version to date in the "sample" project are mixed
SharedKernel
namespaces, using bothClean.Architecture.SharedKernel
andArdalis.SharedKernel
- seems NOK...As I understand it should be used the namespaces
NimblePros.SharedKernel
The text was updated successfully, but these errors were encountered: