Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed SharedKernel : Clean.Architecture and Ardalis #737

Closed
sdudnic opened this issue May 13, 2024 · 7 comments
Closed

Mixed SharedKernel : Clean.Architecture and Ardalis #737

sdudnic opened this issue May 13, 2024 · 7 comments

Comments

@sdudnic
Copy link

sdudnic commented May 13, 2024

In the latest version to date in the "sample" project are mixed SharedKernel namespaces, using both Clean.Architecture.SharedKernel and Ardalis.SharedKernel - seems NOK...

As I understand it should be used the namespaces NimblePros.SharedKernel

@sdudnic sdudnic changed the title Mixed Clean.Architecture.SharedKernel and Ardalis.SharedKernel Mixed SharedKernel : Clean.Architecture and Ardalis May 13, 2024
@ardalis
Copy link
Owner

ardalis commented May 13, 2024

Ah, yeah, that should probably be fixed. Thanks!

@KasinathCR
Copy link

KasinathCR commented Oct 15, 2024

This could well be my first Hacktoberfest issue👍 I would like to help on this.
@ardalis - Could you please assign me this issue?

KasinathCR pushed a commit to KasinathCR/CleanArchitecture that referenced this issue Oct 15, 2024
…ueFix:

1) Replaced Ardalis.SharedKernel with NimblePros.SharedKernel nuget package in Core project
2) Added Ardalis.SharedKernel nuget package in UseCases project as CQRS interfaces are only available in this package
3) Removed Ardalis.SharedKernel nuget package in Infrastructure project
@KasinathCR
Copy link

Hi @ardalis, I've added the PR below fixing the issue. Kindly review it & let me know on any feedback:
#841

@ardalis
Copy link
Owner

ardalis commented Oct 16, 2024

Ok looking at this and the first sentence above I agree with (don't use Clean.Architecture.SharedKernel and Ardalis.SharedKernel) but I realize after reviewing the PR that I don't know about using NimblePros.SharedKernel which has very few downloads and isn't set up currently as a repo anywhere (apparently I published it in 2022 but I'm not sure now 2 years later what my plan was then).

So, if you want to adjust your PR to just use Ardalis.SharedKernel for everything that'd be great and I'll try to figure out my future plans for NimblePros.SharedKernel (if any). Thanks!

@ardalis
Copy link
Owner

ardalis commented Oct 16, 2024

Ok I figured it out. The NimblePros.SharedKernel package is meant to only ever be used by the Sample app which also uses NimblePros as its main namespace. I just need to document that better in the NuGet package so I remember it (and maybe add it to the README in the sample if it's not already there).

That being said...

All references to shared kernel in the sample should use the NimblePros.SharedKernel package and namespace.

I'm in the process of doing major updates to the sample myself which will likely include updating the SharedKernel package version so we'll see how this merges in.

@sdudnic
Copy link
Author

sdudnic commented Oct 22, 2024

All references to shared kernel in the sample should use the NimblePros.SharedKernel package and namespace.

when used as base for other projects, "NimblePros" is meant to be replaced with "Contoso" of each of the forked user projects.

@ardalis
Copy link
Owner

ardalis commented Oct 22, 2024

Right, exactly. Unfortunately it looks like I just did a Visual Studio Publish to create that Nuget package, so I'll need to do that again sometime soon so that it gets the latest updates that are in Ardalis.SharedKernel. It's on my backlog...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants