Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did you make DefaultDelivery as internal ? #1793

Closed
viter-sweatcon opened this issue Jan 3, 2023 · 3 comments
Closed

Why did you make DefaultDelivery as internal ? #1793

viter-sweatcon opened this issue Jan 3, 2023 · 3 comments

Comments

@viter-sweatcon
Copy link

viter-sweatcon commented Jan 3, 2023

I want to debug content and size of my events, metadata and so on. Most easy way which I found was to add middleware to Delivery but it's no possible with current API. What is a goal of this API decision ? I cant event spoof config to intercept DefaultDelivery creating to wrap it :( Is it possible to change api ?

@johnkiely1
Copy link
Member

Hi @viter-sweatcon,

You can create your own delivery implementation. Details on how to do this are here: https://docs.bugsnag.com/platforms/android/configuration-options/#delivery

It's not clear what your use case is exactly but, you can also get access to any/all individual events prior to it being sent via a callback: https://docs.bugsnag.com/platforms/android/customizing-error-reports/#updating-events-using-callbacks

Hope that helps.

@johnkiely1 johnkiely1 added the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jan 9, 2023
@viter-sweatcon
Copy link
Author

Thanks :) I don't really want to write my own delivery interface implementation. For example I want to change algorithm of shrinking metadata or events i.e. request's payload and writing my own delivery for this is looks like to much. It will be better for me to wrap existed DefaultDelivery.

@johnkiely1 johnkiely1 removed the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jan 10, 2023
@johnkiely1
Copy link
Member

Hi @viter-sweatcon,

I can understand your point, but at the same time I don't think we would want to make the class public either. As a workaround we could suggest you just copy the DefaultDelivery code as your own implementation and then modify this to suit your needs.

@johnkiely1 johnkiely1 added the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jan 10, 2023
@luke-belton luke-belton removed the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants