-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Docker image #41
Comments
Agreed, but unfortunately I don't have access either. Probably something @paulmelnikow will have to create, though also likely makes sense for more than one person to have access (assuming Dockerhub supports it) |
yes please, any update on this? I'd love to be able to run this, as was reading https://github.com/badges/shields/blob/master/doc/self-hosting.md which lead me here, but there's no easy way to run this raster server. |
Thanks for sharing your perspective @ghostsquad! Few things I'd note:
The absence of shared updates on any badges/* repositories we manage should be explicitly interpreted as meaning there are no updates. While the occasional reminder bump on old issues can serve some utility, there's really no need to ask about updates especially on relatively new threads like this one (we do a pretty good job of sharing updates as and when they become available). The blocker posted above over the last few weeks remains in place.
I'd actually push back on this a little. Docker is the great unifier and simplifier, and the way you'd run this server with docker is exactly the same regardless of where the image comes from. We obviously want to get prebuilt images available on a major registry where it can simply be pulled, but the image can be built trivially by cloning the repo and running canonical docker commands, e.g. git clone
cd squint
docker build . ....
docker run ... |
Indeed, it looks like building from source sounds to be pretty trivial. I'm looking forward to getting this up and running, and when I do, I'd be happy to contribute back. Thanks for the reply. |
That'd be awesome 🚀 Let us know (here and/or on Discord) if you have any issues! |
Actually, I forgot we hadn't merged the contributing docs (https://github.com/badges/squint/blob/fcb60e4ab812da165ce25401e4eedb2a18677f3e/CONTRIBUTING.md) not exactly thorough yet but may be of some use given the docker section at the bottom |
Any updates here? |
The clean building of the Docker image takes quite a while (as it has to perform a complete build of the application, preferably in Release mode), so it'd be great for us to publish the image, presumably to Dockerhub, so that consumers can simply pull and run the image.
Here's the workflow we have to publish the image for the main Badge Server that should serve as a useful reference
https://github.com/badges/shields/blob/master/.github/workflows/publish-docker-next.yml
To control the build mode, be sure the docker build arg
CARGO_BUILD_MODE
is set torelease
The text was updated successfully, but these errors were encountered: