Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added createPoolWithMaxReuseCount #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junjihashimoto
Copy link

Add max reuse count for createPool.
When reuse count reaches maxReuseCount, reaper destroys the resource.
It is usefull to avoid resource leak.

@junjihashimoto
Copy link
Author

Hi,

If you have time, could you see this?
I would appreciate it if I could receive a comment from you.
How do you think this patch?

@plaprade
Copy link

Hi, I was looking for a pool that would close resources after they have been used a certain number of times. This is useful when your resources grow larger as they are being used (with or without any memory leaks). I would look forward to seeing such functionality being available in a mainstream pool package.

@avanov
Copy link

avanov commented Dec 14, 2021

@junjihashimoto @plaprade if you are still interested, I'd be able to merge this PR into my fork that already includes other PRs from this main repository: one, two, three. But I'd have to ask your help to rebase your branch on the latest master branch of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants