Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added region as a parameter for aws-mfa. #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shantanugupta
Copy link

Regarding the issue(#76), I changed the code. Since I tested when calling sts API without region vs with region. Boto3 resolved to the correct API endpoint when the region was passed. So I made the change to the code to make the package accept region as an additional parameter.

Assumption: .aws/credentials file should contain the region as a required parameter.

@abrockmeyer-govtact
Copy link

Please allow this to merge into the repo. I too had this issue for govcloud

@hmoffatt
Copy link

This is also needed to work with S3 Multi Region Access Points, which don't work with temporary credentials from the global STS endpoint. https://docs.aws.amazon.com/AmazonS3/latest/userguide/MultiRegionAccessPointRestrictions.html

@hmoffatt
Copy link

The commit here is not enough, you must also set the endpoint_url when creating the client. See #52 which has it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants