refactor: event advanced web wrapper #16711
Merged
+98
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
E2E results are ready! |
packages/platform/atoms/event-types/wrappers/EventAdvancedWebWrapper.tsx
Outdated
Show resolved
Hide resolved
| @@ -304,6 +304,7 @@ const AppearanceView = ({ | |||
| description={t("bookerlayout_user_settings_description")} | |||
| isDisabled={isBookerLayoutFormSubmitting || !isBookerLayoutFormDirty} | |||
| isLoading={mutation.isPending} | |||
| user={user} | |||
There was a problem hiding this comment.
can you give some context on this change ?
SomayChauhan
commented
Sep 23, 2024
SomayChauhan
commented
Sep 30, 2024
|
|
||
| const EventAdvancedWebWrapper = (props: EventAdvancedWebWrapperProps) => { | ||
| const connectedCalendarsQuery = trpc.viewer.connectedCalendars.useQuery(); | ||
| const { data: user, isPending } = trpc.viewer.me.useQuery(); |
There was a problem hiding this comment.
will move further up the tree after #16808 (comment) is merged
ThyMinimalDev
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduced a new EventAdvancedWebWrapper component to centralize all TRPC endpoint calls, improving data handling and separation of concerns.
Refactored the existing EventAdvancedTab and all its children components into (dumb) components, shifting all TRPC calls and logic to the newly created parent wrapper (EventAvailabilityTabWebWrapper). It now solely handles UI rendering, receiving data and callbacks as props from its parent.
Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
Mandatory Tasks (DO NOT REMOVE)