Correct NoEnumTrailingCheck and UnnessaryEnumSemicolonCheck to handle empty enums #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regression for NoEnumTrailingCommaCheck: https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/8653_fix_failure_on_empty_enum_2021131932/reports/diff/index.html No diff |
|
@strkkk , please rebase and update PR title and description to define target of fix |
strkkk
added a commit
to strkkk/checkstyle
that referenced
this pull request
Feb 13, 2021
1f7b2d8
to
04a5bcb
Compare
|
@romani done |
romani
reviewed
Feb 13, 2021
| @@ -123,17 +124,16 @@ | |||
|
|
|||
| @Override | |||
| public int[] getRequiredTokens() { | |||
| return new int[] {TokenTypes.ENUM_CONSTANT_DEF}; | |||
| return new int[] {TokenTypes.ENUM_DEF}; | |||
There was a problem hiding this comment.
it is not breaking compatibility, such token is not adjustable by user so users are not affected
romani
requested changes
Feb 13, 2021
.../puppycrawl/tools/checkstyle/checks/coding/noenumtrailingcomma/InputNoEnumTrailingComma.java
Outdated
Show resolved
Hide resolved
04a5bcb
to
15af175
Compare
pbludov
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #8653
NoEnumTrailingCheck is rewritten to handle empty enums with only comma as well (there was no violation before since it inspected ENUM_CONSTANT_DEF token instead of ENUM_DEF).
UnnessaryEnumSemicolonCheck test inputs were extended with enum with only comma.