Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for .matches macro on String #49

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Added support for .matches macro on String #49

merged 2 commits into from
Jun 19, 2024

Conversation

alexsnaps
Copy link
Contributor

Fixes #48

clarkmcc
clarkmcc requested changes Jun 19, 2024
View reviewed changes
interpreter/src/functions.rs Outdated Show resolved Hide resolved
alexsnaps
alexsnaps commented Jun 19, 2024
View reviewed changes
interpreter/src/lib.rs
Err(
FunctionError {
function: "matches".to_string(),
message: "'(foo' not a valid regex:\nregex parse error:\n (foo\n ^\nerror: unclosed group".to_string()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this makes sense now

clarkmcc
clarkmcc approved these changes Jun 19, 2024
View reviewed changes
Copy link
Owner

@clarkmcc clarkmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks!

@clarkmcc clarkmcc merged commit 1c5b0c6 into clarkmcc:master Jun 19, 2024
1 check passed
@alexsnaps alexsnaps deleted the fn_matches branch June 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkmcc clarkmcc clarkmcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex support?
2 participants
@alexsnaps @clarkmcc