-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support "podman network ls --filter dangling=true" #14595
Comments
@cdoern PTAL |
Hey, I am new to podman and I'd like to work on this if possible |
You got it. |
I had a look at it and, my assumptions are: A: the filtering function is the one created in About (A), I think I could even patch libnetwork, but the logic implemented in (B) makes use of the list of all containers, which I believe libnetwork does not have access to, nor it needs to know. Regarding the tests, I think the new test shall go into If that so, I could use |
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
add the ability to filter networks by their dangling status via: `network ls --filter dangling=true/false` Fixes: containers#14595 Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind feature
Description
The docker.el module for Emacs (see https://github.com/Silex/docker.el) uses "podman network ls --filter dangling=true"). Unfortunately, Podman doesn't support this yet.
Steps to reproduce the issue:
Emacs runs first
to get all networks available and then it runs
to get only the dangling ones. It uses this information to mark the dangling ones for it's GUI display.
This last call however returns an error:
Additional information you deem important (e.g. issue happens only occasionally):
Output of
podman version
:Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)
Sure
Commands that support dangling=true already
Emacs also uses
These commands support the dangling filter.
The text was updated successfully, but these errors were encountered: