Add scrollbar to leaderboard #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewejones I am not sure whether this is the optimal solution. I mean, we added the ticks to indicate which user already passed. We are kind of giving this up when making the table scroll (at least, for most times you don't have an overview over all players anymore without scrolling). Also, I am not sure if supporting smaller screens is high priority. Most developers usually have large monitors... I am kind of tempted to drop this issue for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves issue #110 by adding a scroll bar to the leaderboard.
So far I've been unable to keep the border below the heading once you've scrolled while also keeping the table aligned. I think if I were to manually set the width of the columns it would be possible
The other option is to have the headings scroll with the rest of the table. i.e. have it not be fixed/sticky.
Resolves #110