[Kernel] Handle long values in FieldMetadata parsing
#3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonport-db
approved these changes
May 31, 2024
richardc-db
pushed a commit
to richardc-db/delta
that referenced
this pull request
Jun 5, 2024
## Description Currently when parsing the `FieldMetadata` in `StructField` (as part of the schema parsing), we always assume the integral values are of `int` type, but it could be of value `long`. ## How was this patch tested? Add couple of cases to existing test
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
Aug 30, 2024
…#3186) Currently when parsing the `FieldMetadata` in `StructField` (as part of the schema parsing), we always assume the integral values are of `int` type, but it could be of value `long`. Add couple of cases to existing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when parsing the
FieldMetadatainStructField(as part of the schema parsing), we always assume the integral values are ofinttype, but it could be of valuelong.How was this patch tested?
Add couple of cases to existing test