Refresh pre signed urls in Spark connector #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, To summarize:
|
FX196
approved these changes
Oct 27, 2021
|
qq: It is correct that we don't need to worry about cache validity since Delta creates new files to replace the old files when there is an update? |
Yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when reading a Delta Sharing table, we generate the pre signed urls first and use them to read. However, for a long running query, the pre signed urls may expire before we try to read them.
This PR adds a pre signed url cache in Spark driver. It will refresh pre signed urls in a background thread. Tasks running in Spark executors will talk to the Spark driver to fetch pre signed urls. This will ensure when we read a file in an executor, it will always get the latest valid pre signed url.