Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDs listed in red but don't seem to be deprecated #2836

Open
ybizeul opened this issue Aug 19, 2024 · 5 comments
Open

CRDs listed in red but don't seem to be deprecated #2836

ybizeul opened this issue Aug 19, 2024 · 5 comments

Comments

@ybizeul
Copy link

ybizeul commented Aug 19, 2024




Describe the bug
Some CRDs appear in red, but not sure what the reason is.
They contain some deprecated versions of their schema, which is pretty standard, but their most recent schema is not deprecated and should be displayed as such it seems

To Reproduce
In my case, I was deploying a kubernetes cluster with CAPI, most controller resource appear red

Historical Documents
This is an example resource that shows in red

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
[...]
  name: machines.cluster.x-k8s.io
spec:
  conversion:
    strategy: Webhook
    webhook:
[...]
      conversionReviewVersions:
      - v1
      - v1beta1
  group: cluster.x-k8s.io
  names:
[...]
  scope: Namespaced
  versions:
  - additionalPrinterColumns:
    - description: Provider ID
[...]
    deprecated: true
    name: v1alpha3
    schema:
[...]
    served: false
    storage: false
    subresources:
      status: {}
  - additionalPrinterColumns:
[...]
    deprecated: true
    name: v1alpha4
    schema:
...]
    served: false
    storage: false
    subresources:
      status: {}
  - additionalPrinterColumns:
[...]
    name: v1beta1
    schema:
[...]
    served: true
    storage: true
    subresources:
      status: {}
status:
  acceptedNames:
    categories:
    - cluster-api
    kind: Machine
    listKind: MachineList
    plural: machines
    shortNames:
    - ma
    singular: machine
  conditions:
  - lastTransitionTime: "2024-08-19T09:58:32Z"
    message: no conflicts found
    reason: NoConflicts
    status: "True"
    type: NamesAccepted
  - lastTransitionTime: "2024-08-19T09:58:32Z"
    message: the initial names have been accepted
    reason: InitialNamesAccepted
    status: "True"
    type: Established
  storedVersions:
  - v1beta1

Expected behavior
I think this particular resource should have the standard color (blue)

Screenshots
image

Versions (please complete the following information):

  • OSX
  • K9s: 0.32.5
  • K8s: v1.31.0
@wjiec
Copy link
Contributor

wjiec commented Aug 20, 2024 •
edited
Loading

If a version in crd is “deprecated” or NOT “served” it will be red, you can check the VALID field to see why by ctrl + w.

@ybizeul
Copy link
Author

ybizeul commented Aug 20, 2024

Not sure I understand why a version not served AND deprecated would be a problem. Seems like pretty standard CRD lifecycle stuff or am I missing something ?

@wjiec
Copy link
Contributor

wjiec commented Aug 20, 2024

Uh-huh, I think it's just “reusing” the color “red” by the way, it doesn't mean “error” or anything like that. Just highlighting it? 🤔️

@ybizeul
Copy link
Author

ybizeul commented Aug 20, 2024

Same as CrashLoopBackOff and Error containers ? In any case that's certainly something that drains more attention than it should.

@wjiec
Copy link
Contributor

wjiec commented Aug 20, 2024

Indeed, it might be a bit better to change the color or express it in some other way (e.g. using 🗑 or ⚠️ or something like that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ybizeul @wjiec