Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to accomodate build on Windows #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes to accomodate build on Windows #11

wants to merge 2 commits into from

Conversation

davidtgillard
Copy link

  • removed librt dependency
  • specify C++11 as standard
  • remove some compiler flags
  • added WindowsUtcTimeSource singleton class (determines if GetSystemTimePreciseAsFileTime is available)
  • updated DateTime::Now to use WindowsUtcTimeSource if compiling on Windows

dnwrnr
dnwrnr reviewed Oct 18, 2018
View reviewed changes
Copy link
Owner

@dnwrnr dnwrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back compiler flags for non windows.
Why remove LIBRARY from install(TARGETS sgp4s LIBRARY DESTINATION lib)
Given this is c++11 compliant, you should be using std::chrono::system_clock etc

@davidtgillard
Copy link
Author

Apologies for the delay in response.

  • Compiler flags: no problem.
  • I removed the LIBRARY target specifier was removed from the install command for sgp4s because shared libraries are treated as runtime objects. It exhibits the same behaviour without the target specifier when I build on linux/mac.
  • From what I've read, the epoch of std::chrono::system_clock is de facto the unix epoch (seems to be the case between the major compilers)...but I suppose it's not technically guaranteed. The alternative is that ugly workaround - I'll do whichever you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwrnr dnwrnr dnwrnr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidtgillard @pxntus @dnwrnr