-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generic resources to bash completion #749
Conversation
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 218 218
Lines 14613 14613
=======================================
Hits 7811 7811
Misses 6321 6321
Partials 481 481 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, but LGTM otherwise
contrib/completion/bash/docker
Outdated
@@ -3459,6 +3461,8 @@ _docker_service_update_and_create() { | |||
--dns-search-rm | |||
--group-add | |||
--group-rm | |||
--generic-resource-add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to keep this alphabetical? If so, it should be above the --group-...
lines 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alphabet is really comlicated...
Thanks for catching. PR is updated.
Adds bash completion for - `service create --generic-resource` - `service update --generic-resource-(add|rm)` - `dockerd --node-generic-resource` Signed-off-by: Harald Albers <github@albersweb.de>
3373a60
to
8ec80ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
😄 thanks! merging, so that I can cherry-pick |
Adds bash completion for #429:
service create --generic-resource
service update --generic-resource-(add|rm)
dockerd --node-generic-resource