-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE0036 errors when building with Preview 6 SDK #11493
Comments
We have it set to a warning in the CodeAnalysis globalconfig. Maybe it isn't getting applied to winforms/eng/CodeAnalysis.src.globalconfig Lines 1541 to 1542 in aa61778
|
Source-build and unified-build use There are more errors, of the same type: dotnet/sdk#41417 (comment) |
We have |
@sharwell |
Maybe caused by dotnet/roslyn#73339? i.e. it was silently ignored before that fix |
Any update on this? We still have a patch for it in the VMR: https://github.com/dotnet/sdk/blob/main/src/SourceBuild/patches/winforms/0001-Suppress-IDE0036-errors.patch |
@ViktorHofer we think it's a Roslyn bug? The analyzer isn't firing for us. |
@elachlan I hacked the System.Drawing.Common build so it still built with the 8.0.100 SDK and it does show the same analyzer errors there so I'm almost certain that it was just silently ignored on 8.0.200+ until the fix in dotnet/roslyn#73339 So these look like genuine findings. You can bump the SDK version to e.g. |
Opened a PR: #11571 |
Sent from my iPhoneOn Jun 5, 2024, at 11:51 PM, Lachlan Ennis ***@***.***> wrote:
We have TreatWarningsAsErrors=true in our CI builds. I also locally set the analyzer to error instead of warning and didn't get any hits. Its like the analyzer isn't getting run.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
When building with .NET 9 Preview 6 SDK (i.e. 9.0.100-preview.6.24303.27), there are 3 IDE0036 errors:
From: dotnet/sdk#41417 (comment)
The text was updated successfully, but these errors were encountered: