Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: Respect DebugSymbols=false #41400

Closed
1 of 3 tasks
Forgind opened this issue Jun 11, 2024 · 0 comments · Fixed by #41957
Closed
1 of 3 tasks

[Breaking change]: Respect DebugSymbols=false #41400

Forgind opened this issue Jun 11, 2024 · 0 comments · Fixed by #41957
Assignees
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 8 Work items for the .NET 8 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@Forgind
Copy link
Member

Forgind commented Jun 11, 2024

Description

Our documentation says that DebugSymbols=false, when specified from the command line, means we won't output pdbs. That isn't currently true, and we don't know for how long that hasn't been true. This changes it such that that is now true: DebugSymbols=false suppresses pdb generation by changing DebugType to None.

Customers who currently have a script that includes -p:DebugSymbols=false may currently be expecting pdbs to be created because that is current behavior, and that will change with this.

Version

.NET 8 GA

Previous behavior

-p:DebugSymbols=false did not suppress pdb generation.

New behavior

-p:DebugSymbols=false now suppresses pdb generation.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code may require source changes to compile successfully.
  • Behavioral change: Existing binaries may behave differently at run time.

Reason for change

This aligns with our documentation and user expectations. It has led to confusion in the past.

Recommended action

If a user wants to generate pdbs, do not specify -p:DebugSymbols=false on the command line. Simply remove that property, and they will be generated again.

Feature area

SDK

Affected APIs

N/A


Associated WorkItem - 286584

@Forgind Forgind added doc-idea Indicates issues that are suggestions for new topics [org][type][category] breaking-change Indicates a .NET Core breaking change Pri1 High priority, do before Pri2 and Pri3 labels Jun 11, 2024
@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged labels Jun 11, 2024
@gewarren gewarren added 🏁 Release: .NET 8 Work items for the .NET 8 release and removed ⌚ Not Triaged Not triaged labels Jun 12, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jun 12, 2024
@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Jun 12, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jun 12, 2024
@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Jul 9, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 9, 2024
@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Jul 9, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 9, 2024
@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Jul 9, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 9, 2024
@gewarren gewarren added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Jul 17, 2024
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Jul 17, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 8 Work items for the .NET 8 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants