Research and add defaults to HTTP resilience content #41611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintmk
reviewed
Jul 1, 2024
martintmk
reviewed
Jul 1, 2024
martintmk
reviewed
Jul 1, 2024
Co-authored-by: martintmk <103487740+martintmk@users.noreply.github.com>
martincostello
approved these changes
Jul 2, 2024
martintmk
reviewed
Jul 2, 2024
| Additionally, these strategies handle the following exceptions: | ||
|
|
||
| - `HttpRequestException` | ||
| - `TimeoutRejectedException` |
There was a problem hiding this comment.
Can we do the same thing for hedging? Just add circuit breaker exception too.
There was a problem hiding this comment.
I'm not sure I follow. So, the Hedging handler employs what defaults?
There was a problem hiding this comment.
Hedging has different ShouldHandle predicate compared to standard resilience:
Maybe just note that status codes/exceptions are the same as compared to standard resilience, but hedging strategy also handles BrokenCircuitException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Researched and add defaults to HTTP resilience content
Fixes #41610 — CC: @martincostello
Internal previews