Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the binary_analysis link in favor of upgrade-with-the-cli-tool section of .NET Upgrade Assistant tool page #41674

Merged

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Jul 8, 2024

This pull request fixes #41638.
It removes the binary_analysis link due to dotnet/upgrade-assistant#1555 (comment) and replaces it with more direct link to .NET Upgrade Assistant tool page just like it was done in #41395.


Internal previews

📄 File 🔗 Preview link
docs/core/porting/third-party-deps.md Analyze your dependencies to port code from .NET Framework to .NET

@BartoszKlonowski BartoszKlonowski requested a review from a team as a code owner July 8, 2024 23:12
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 8, 2024
@BartoszKlonowski
Copy link
Contributor Author

I see the bot couldn't figure out the reviewers, so let me kindly ping
@gewarren @BillWagner
🙏

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/core/porting/third-party-deps.md Outdated Show resolved Hide resolved
@gewarren gewarren enabled auto-merge (squash) July 9, 2024 00:04
@gewarren gewarren merged commit 925ca63 into dotnet:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing link
3 participants