Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please suggest the Editor to use for the C# code elements. Please consider producing a version of this tutorial to follow inside of VS #6218

Open
rstannard opened this issue Jun 29, 2018 — with docs.microsoft.com · 13 comments
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] dotnet-fundamentals/svc Pri2
Milestone

Comments

Copy link

rstannard commented Jun 29, 2018

I've just completed following this tutorial and found it very helpful. I would just make the following comments how it could be slightly improved.
1/ please advise the reader that this tutorial is aimed to be followed outside of the Visual Studio 2017 environment.
2/ if (1) is the case then please suggest an editor to use for completing the code in.
I followed the tutorial using a mix of following the command line steps to create the project structure as well as VS2017 for the C# code pieces.
3/ it would be very useful to see a version of this tutorial which shows the steps to follow inside of VS.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@rprouse
Copy link
Contributor

rprouse commented Jun 29, 2018

Good suggestions, thanks. You might want to change the title of this issue to something more meaningful since this repo is for all of the .NET Core documentation. I would do it, but I don't have edit rights in this repository.

@rstannard rstannard changed the title Helpful tutorial Please suggest the Editor to use for the C# code elements. Please consider producing a version of this tutorial to follow inside of VS Jun 29, 2018
@rstannard
Copy link
Author

rstannard commented Jun 29, 2018

Hi Rob, I've just done that now - I hope its not too wordy ? Happy to take a suggestion.

Copy link

Rather/as well as than using shell commands, which may be confusing to those new to Visual Studio (like myself), I'd recommend including in-GUI ways to do the same thing.

dotnet new -i NUnit3.DotNetNew.Template can be avoided by installing the NUnit VS Packages from the Marketplace within Visual Studio, for example, and adding new solutions and linking references are fairly simple to do from within the Visual Studio UI.

@mairaw mairaw added 📚 Area - .NET Core Guide doc-idea Indicates issues that are suggestions for new topics [org][type][category] labels Aug 31, 2018
@mairaw mairaw added this to the Backlog milestone Aug 31, 2018
@mairaw
Copy link
Contributor

mairaw commented Aug 31, 2018

Thanks for your feedback @rstannard. I'm adding this to our backlog. We usually start the topics with the CLI version since it's cross-platform, but indeed topics using VS would also be useful.

/cc @BillWagner

Copy link

I strongly discourage using VS or Code as long as they are not helpful. I suggest .NET core for Linux and the bash CLI in conjunction with gedit, atom, vim or some other Linux editor available.

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Dec 4, 2019

@Thraka recommend closing this issue. VS is fine as the editor. This tutorial is consistent with all the rest of the unit testing tutorials.

Unit testing is generally not the onboarding/most beginning tutorial.

@Thraka
Copy link
Contributor

Thraka commented Dec 5, 2019

@mairaw owns this article so I would let her make the call, but I agree. It will all be rewritten anyhow when these get remade.

@adegeo adegeo self-assigned this Jun 23, 2020
@Thraka Thraka removed their assignment Jun 23, 2020
@StingyJack
Copy link
Contributor

@Rick-Anderson yeah but someone who is skilled with VS and familiar with unit testing cant actually follow these instructions and get a working result. at least not without monkeying and web searching a bit. For example I would never think to choose a console application as the project type, but Nunit seems to need that. The doc page even says

You've built a small library and a set of unit tests for that library

Then again I wouldnt bother typing most of the stuff in these "tutorials" when I can hit 3 or 4 keys in a VS shortcut. It may be a GUI but its still only 3 or 4 keys compared to typing "dotnet ".

@dotnet-bot
Copy link
Contributor

This issue has been closed as part of the issue backlog grooming process outlined in #22351.

That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs team for visibility.

@dotnet-bot dotnet-bot added the won't fix Issues that were closed as part of automated backlog grooming label Jan 25, 2021
@adegeo
Copy link
Contributor

adegeo commented Jan 25, 2021

@BillWagner @IEvangelist I think this one should be reopened. We really should have parity on these unit test articles for cli, visual studio, visual studio for mac.

Thoughts?

@IEvangelist
Copy link
Member

@BillWagner Bill Wagner FTE @IEvangelist David Pine FTE I think this one should be reopened. We really should have parity on these unit test articles for cli, visual studio, visual studio for mac.

Thoughts?

I think that we have consistent and uniform coverage so far. The articles require the SDK and your IDE of choice. I think that is sufficient, otherwise it becomes too repetitive. I believe that is the advantage to using the SDK, it is agnostic to IDE preference. If our instructions did not work, however; on a specific OS or IDE choice then we should fix it. I'm good with this one being closed. @BillWagner thoughts?

@sharwell sharwell removed the won't fix Issues that were closed as part of automated backlog grooming label Jan 26, 2021
@sharwell
Copy link
Member

Since a bot closed this and a user requested it be reopened, I'll do so now. Note that it may be closed again by a human per #6218 (comment).

@sharwell sharwell reopened this Jan 26, 2021
@StingyJack
Copy link
Contributor

@IEvangelist - try following them with VS 2019 and assume you have only used MSFT's flagship unit testing platform before (since it has always been able to meet the need) and that you are not familiar with nunit or xunit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] dotnet-fundamentals/svc Pri2
Projects
None yet
Development

No branches or pull requests