Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for numerous IXCLRData* DAC interfaces, methods, and related structures / enumerations #41675

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

wmessmer-msft
Copy link

@wmessmer-msft wmessmer-msft commented Jul 8, 2024

Summary

Adds new documentation for various IXCLRData* DAC interfaces, methods, and related structures / enumerations. Such includes new method documentation for various methods on IXCLRDataProcess, IXCLRDataModule, IXCLRDataMethodInstance, and XCLRDataMethodDefinition. It also includes new interface descriptions and related method definitions for various parts of IXCLRDataTask, IXCLRDataFrame, IXCLRDataValue, IXCLRDataStackWalk, IXCLRDataTypeInstance, IXCLRDataTypeDefinition, IXCLRDataExceptionState, and the various revisions of IXCLRDataExceptionNotification. Related enumerations and structures to any newly documented interfaces and methods are also added.

All of this follows the style of the existing IXCLRData* documentation including the warning note that callers should prefer the much better supported DBI (ICorDebug) interfaces.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/framework/unmanaged-api/debugging/clrdatadetailedframetype-enumeration.md CLRDataDetailedFrameType Enumeration
docs/framework/unmanaged-api/debugging/clrdatafieldflag-enumeration.md "CLRDataFieldFlag Enumeration"
docs/framework/unmanaged-api/debugging/clrdatavalueflag-enumeration.md CLRDataValueFlag Enumeration
docs/framework/unmanaged-api/debugging/debugging-enumerations.md docs/framework/unmanaged-api/debugging/debugging-enumerations
docs/framework/unmanaged-api/debugging/debugging-interfaces.md Debugging Interfaces
docs/framework/unmanaged-api/debugging/debugging-structures.md "Debugging Structures"
docs/framework/unmanaged-api/debugging/gcevtargs-structure.md GcEvtArgs Structure
docs/framework/unmanaged-api/debugging/ixclrdataexceptionstate-issamestate-method.md IXCLRDataExceptionState::IsSameState Method
docs/framework/unmanaged-api/debugging/ixclrdataexceptionstate-issamestate2-method.md docs/framework/unmanaged-api/debugging/ixclrdataexceptionstate-issamestate2-method
docs/framework/unmanaged-api/debugging/ixclrdataexceptionstate-request-method.md IXCLRDataExceptionState::Request Method
docs/framework/unmanaged-api/debugging/ixclrdataframe-getargumentbyindex-method.md "IXCLRDataFrame::GetArgumentByIndex Method"
docs/framework/unmanaged-api/debugging/ixclrdataframe-getlocalvariablebyindex-method.md IXCLRDataFrame::GetLocalVariableByIndex Method
docs/framework/unmanaged-api/debugging/ixclrdatamethoddefinition-interface.md docs/framework/unmanaged-api/debugging/ixclrdatamethoddefinition-interface
docs/framework/unmanaged-api/debugging/ixclrdatamethoddefinition-request-method.md IXCLRDataMethodDefinition::Request Method
docs/framework/unmanaged-api/debugging/ixclrdatamethodinstance-getaddressrangesbyiloffset-method.md IXCLRDataMethodInstance::GetAddressRangesByILOffset Method
docs/framework/unmanaged-api/debugging/ixclrdatamethodinstance-interface.md "IXCLRDataMethodInstance Interface"
docs/framework/unmanaged-api/debugging/ixclrdatamethodinstance-request-method.md IXCLRDataMethodInstance::Request Method
docs/framework/unmanaged-api/debugging/ixclrdatamodule-interface.md docs/framework/unmanaged-api/debugging/ixclrdatamodule-interface
docs/framework/unmanaged-api/debugging/ixclrdatamodule-startenummethodinstancesbyname-method.md IXCLRDataModule::StartEnumMethodInstancesByName Method
docs/framework/unmanaged-api/debugging/ixclrdataprocess-followstub-method.md "IXCLRDataProcess::FollowStub Method"
docs/framework/unmanaged-api/debugging/ixclrdataprocess-followstub2-method.md IXCLRDataProcess::FollowStub2 Method
docs/framework/unmanaged-api/debugging/ixclrdataprocess-interface.md docs/framework/unmanaged-api/debugging/ixclrdataprocess-interface
docs/framework/unmanaged-api/debugging/ixclrdataprocess-request-method.md IXCLRDataProcess::Request Method
docs/framework/unmanaged-api/debugging/ixclrdataprocess-setcodenotifications-method.md IXCLRDataProcess::SetCodeNotifications Method
docs/framework/unmanaged-api/debugging/ixclrdatastackwalk-request-method.md "IXCLRDataStackWalk::Request Method"
docs/framework/unmanaged-api/debugging/ixclrdatatypeinstance-getstaticfieldbyindex-method.md IXCLRDataTypeInstance::GetStaticFieldByIndex Method
docs/framework/unmanaged-api/debugging/ixclrdatavalue-enumfield-method.md docs/framework/unmanaged-api/debugging/ixclrdatavalue-enumfield-method
docs/framework/unmanaged-api/debugging/ixclrdatavalue-getarrayproperties-method.md IXCLRDataValue::GetArrayProperties Method
docs/framework/unmanaged-api/debugging/ixclrdatavalue-request-method.md "IXCLRDataValue::Request Method"
docs/framework/unmanaged-api/debugging/ixclrdatavalue-startenumfieldsbyname-method.md IXCLRDataValue::StartEnumFieldsByName Method

Note

This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

@wmessmer-msft wmessmer-msft requested a review from a team as a code owner July 8, 2024 23:34
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 8, 2024
@noahfalk
Copy link
Member

noahfalk commented Jul 9, 2024

Just a heads up @dotnet/docs, these are old debugging APIs that were originally defined for .NET Framework but have long been private. In the past we made a few selected APIs public to aid debugging tools but now we are adding a bunch more to assist some diagnostic tooling partners that wanted to call them. We expect extremely few people to use these APIs (<10 in the world?). Given the very narrow audience that would ever look at these pages and that we expect those folks to already have area expertise we are trying to keep effort on the docs minimal. While we do care about having a basic doc available I expect time spent on editorial improvements will have very low payoff given the tiny audience.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files at least need to be added to the TOC so they're not orphaned - that file is here. Ideally they'd also be added to the overview pages such as https://github.com/dotnet/docs/blob/main/docs/framework/unmanaged-api/debugging/debugging-structures.md for structures.

There are also some warnings to address here - LMK if you need help with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-framework/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants