Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about writing managed wrappers #41746

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Add note about writing managed wrappers #41746

merged 3 commits into from
Jul 14, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Jul 12, 2024 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 12, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review July 13, 2024 17:19
@AaronRobinsonMSFT
Copy link
Member Author

/cc @gewarren

gewarren
gewarren approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left a couple suggestions.

docs/standard/native-interop/best-practices.md Outdated Show resolved Hide resolved
docs/standard/native-interop/best-practices.md Outdated Show resolved Hide resolved
@AaronRobinsonMSFT @gewarren
Apply suggestions from code review
5846bfb 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 28c0d30 into dotnet:main Jul 14, 2024
8 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the wrappers branch July 14, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@jkotas jkotas jkotas approved these changes

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AaronRobinsonMSFT @jkoritzinsky @jkotas @gewarren @dotnet-bot