Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RabbitMQ docs usage of AddRabbitMQ for connection string based connection #1057

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix RabbitMQ docs usage of AddRabbitMQ for connection string based connection #1057

merged 3 commits into from
Jun 10, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jun 10, 2024 •
edited by github-actions bot
Loading

@eerhardt eerhardt requested a review from davidfowl June 10, 2024 16:53
@dotnet-bot dotnet-bot added the messaging Content related to messaging. label Jun 10, 2024
@IEvangelist IEvangelist enabled auto-merge (squash) June 10, 2024 18:02
@eerhardt
Copy link
Member Author

@IEvangelist - I don't see why your 2nd commit was made to this PR. It seems unrelated.

@IEvangelist
Copy link
Member

IEvangelist commented Jun 10, 2024 •
edited
Loading

@IEvangelist - I don't see why your 2nd commit was made to this PR. It seems unrelated.

Hey @eerhardt - There was a build issue that was blocking this PR from being merged, I was trying to fix that. See here.

@IEvangelist IEvangelist merged commit 672d7a8 into main Jun 10, 2024
7 checks passed
@IEvangelist IEvangelist deleted the eerhardt-patch-1 branch June 10, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
messaging Content related to messaging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix RabbitMQ docs usage of AddRabbitMQ for connection string based connection
3 participants
@eerhardt @IEvangelist @dotnet-bot