Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show contentFiles from nuget packages in legacy project system #3431

Open
nkolev92 opened this issue Mar 29, 2018 · 7 comments
Open

Show contentFiles from nuget packages in legacy project system #3431

nkolev92 opened this issue Mar 29, 2018 · 7 comments
Labels
Feature Request Request for a new feature, or new scenario to be handled. Legacy Issues against the legacy project system. Triage-Approved Reviewed and prioritized
Milestone

Comments

@nkolev92
Copy link
Contributor

nkolev92 commented Mar 29, 2018

In the new project system, the static contentFiles from Nuget packages are linked and shown in the solution explorer.

oldvsnewcsproj

The old project system should do the same.

Note that CommandStuff.cs is the only element from the package above the needs shown.
It's also marked as a link.

The example illustrates the difference in 15.7 P3.
ClassLibrary1 is legacy, ClassLibrary39 is SDK csproj.

Additionally it's important that these files are read-only.
Related issue to make them read-only in new project system - #2141

As more and more people are moving their projects as part of the effort in NuGet/Home#5877, this becomes more and more important.

//cc @rrelyea @anangaur @davkean

@anangaur
Copy link

anangaur commented Mar 29, 2018

Why does globalpackagesfolder show up here? My understanding was the contents of the contentfiles folder show up in the solution explorer.

@davkean davkean added this to the Unknown milestone Mar 29, 2018
@davkean davkean added Feature Request Request for a new feature, or new scenario to be handled. Legacy Issues against the legacy project system. labels Mar 29, 2018
@nkolev92
Copy link
Contributor Author

@anangaur
That's just my test setup :)
When I test things with packages I build locally, I set the global packages folder to a directory inside the project, to avoid polluting my actual global packages folder.

And new project system just imports/shows everything under the project folder.

@anangaur
Copy link

I guessed so but this makes the screenshot confusing. Can you clarify the following in the description?

  • the content file in this case
  • the layout of the this file in the package.

@bording
Copy link
Contributor

bording commented Apr 6, 2018

One thing missing from how the new project system handles contentFiles is that it doesn't make them read-only, so if you edit them, you're editing the file from the NuGet package cache folder.

When adding contentFiles support to the old project system, would it be possible to make them read-only from the initial implementation?

@nkolev92
Copy link
Contributor Author

nkolev92 commented Apr 6, 2018

@bording
Great point, there's already a task for that.
I've linked it in the original issue.

@bording
Copy link
Contributor

bording commented Nov 14, 2018

@nkolev92 @anangaur Is there any chance of this being addressed in the VS 2019 timeframe?

@tmeschter
Copy link
Contributor

Tom's triage notes: I recommend we close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for a new feature, or new scenario to be handled. Legacy Issues against the legacy project system. Triage-Approved Reviewed and prioritized
Projects
None yet
Development

No branches or pull requests

7 participants