Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically merge all new EIP drafts #5641

Closed
Pandapip1 opened this issue Sep 10, 2022 · 43 comments
Closed

Automatically merge all new EIP drafts #5641

Pandapip1 opened this issue Sep 10, 2022 · 43 comments
Labels
e-consensus Waiting on editor consensus enhancement r-ci Relates to the CI r-process Relates to an EIP Process w-stale Waiting on activity

Comments

@Pandapip1
Copy link
Member

Pandapip1 commented Sep 10, 2022

Proposed Change

Currently, the process for creating an EIP is not very simple and it is pretty time-consuming just to get an EIP to draft. I imagine a large part of the reason that a lot of EIPs end up stagnant is that the effort even to get an EIP into draft is a lot - more than is probably needed when the criteria for drafts, per EIP-1, is them being "properly formatted." We have tooling that lets users know when their EIPs aren't properly formatted, and we might soon have tooling to automatically fix the most common errors.

Currently, when an EIP is initially proposed is when things like "is this EIP ideal for its current purpose" are discussed and block the progress. Having an actual EIP that is being built and on which people can submit PRs that propose changes is, IMHO, better than the status quo, and would actually allow the community to take some of the burden off of the EIP editors.

@Pandapip1 Pandapip1 changed the title Proposal: Automatically merge all new EIP drafts Automatically merge all new EIP drafts Sep 10, 2022
@Pandapip1 Pandapip1 added r-process Relates to an EIP Process r-ci Relates to the CI labels Sep 10, 2022
@SamWilsn
Copy link
Contributor

SamWilsn commented Sep 12, 2022

This seems reasonable. I'd like to have a bit of discussion on it before we make a decision though.

I think we need a few more checks in eipw before I'm comfortable enabling this:


We'd also need an automated EIP number assigner.

@Pandapip1
Copy link
Member Author

I agree that those specific checks should be required.

@Pandapip1 Pandapip1 added the e-consensus Waiting on editor consensus label Sep 15, 2022
@SamWilsn
Copy link
Contributor

@poojaranjan brought up a great point. A lot of EIPs die in the draft stage, so the first pull request is the only point editors have to influence these EIPs.

Plus we want to encourage discussion on magicians before draft, so we get bigger/more developed ideas in the repository.

I am now weakly against this proposal.

@xinbenlv
Copy link
Contributor

I agree.

@Pandapip1
Copy link
Member Author

Pandapip1 commented Oct 27, 2022

I have to disagree here. Editors can always open PRs to modify EIPs (like any other person).

I think that having draft EIPs automatically merge would encourage more participation for draft EIPs, as it gives the Ethereum community a longer time to suggest and make changes formally. As such, the quality of Draft EIPs, on the whole, would be lower, but the quality of EIPs moving to Review would be higher as people would have more time to participate in the horizontal review process.

@Pandapip1
Copy link
Member Author

Would like to bump this.

@lightclient
Copy link
Member

IMO, if we're going to "auto-merge" drafts they should not get an EIP number. Other standards bodies have a draft stage where the proposal has not yet been assigned an RFC number (see Internet-Drafts). I would like to adopt a similar scheme. I think this would be valuable regardless if we move forward with the auto-merge.

@Pandapip1
Copy link
Member Author

I would agree with them not getting an EIP number. And if they become stagnant, I think they could just be deleted. +1

@xinbenlv
Copy link
Contributor

xinbenlv commented Nov 28, 2022

+1

but in that case we need to suggest a standard way for them to create file name with, for example
some mnemonic name, e.g. eip-some-name.md

@Pandapip1
Copy link
Member Author

Nothing says that EIP "numbers" even have to be numeric. EIP editors, right now, could literally assign an EIP "number" of hello. We wouldn't since that would be stupid, but we could do this without too many changes.

CC @SamWilsn, how feasible would this be to add to EIPw?

@lightclient
Copy link
Member

I think they should have a different prefix completely to avoid any confusion.

@Pandapip1
Copy link
Member Author

I think they should have a different prefix completely to avoid any confusion.

How about EIP-draft-X and ERC-draft-X?

@xinbenlv
Copy link
Contributor

xinbenlv commented Dec 2, 2022

How about EIP-draft-X and ERC-draft-X?

Sounds good.

X could be ether a number or a mnemonic alias string

@Pandapip1
Copy link
Member Author

I was thinking of a mnemonic, like I-Ds.

@xinbenlv
Copy link
Contributor

xinbenlv commented Dec 2, 2022

Mnmonecs sounds good to me. Better than a draft number, reducing chance of confusion with regular EIP number

@sambacha
Copy link
Contributor

@poojaranjan brought up a great point. A lot of EIPs die in the draft stage, so the first pull request is the only point editors have to influence these EIPs.

Plus we want to encourage discussion on magicians before draft, so we get bigger/more developed ideas in the repository.

I am now weakly against this proposal.

Yes good, kill them while the gestate. If you do not have the time to shepherd it through a GitHub pull request what chance do they have of championing it through all the factions in the greater community?

Plus why make more work for yourself, lol.

@Pandapip1
Copy link
Member Author

Pandapip1 commented Dec 20, 2022

Plus why make more work for yourself, lol.

That's the problem I have with having two bars: you are doubling the workload. You have to review it once during draft, and again when it reaches review. The difference is that Review EIPs are typically nicer to review, having been somewhat proofread and shortened. So why not get rid of that first step?

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 26, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 3, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@Pandapip1
Copy link
Member Author

I am very against this change if it assigns them an EIP number. I think it should give a DEIP number or something separate.

It will not. It will assign them a string identifier.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 26, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 5, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 6, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 14, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 15, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 23, 2023
@sambacha
Copy link
Contributor

This is still being discussed is it not?

@Pandapip1
Copy link
Member Author

Yes. The bot is to prompt us to either continue discussion or let it stagnate. I would, again, very much like this.

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 24, 2023
@lightclient
Copy link
Member

Again, I think they should have a different prefix completely to avoid any confusion and gaming of the system.

@Pandapip1
Copy link
Member Author

Pandapip1 commented Mar 24, 2023

I am +0 to a different prefix (not +1 because I would prefer a mnemonic instead, which would require far fewer CI changes)

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 1, 2023
@Pandapip1
Copy link
Member Author

Bump

@github-actions github-actions bot removed the w-stale Waiting on activity label Apr 2, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 10, 2023
@Pandapip1
Copy link
Member Author

Draft EIP numbers are being made possible by #6976

@github-actions github-actions bot removed the w-stale Waiting on activity label May 3, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus enhancement r-ci Relates to the CI r-process Relates to an EIP Process w-stale Waiting on activity
Projects
None yet
Development

No branches or pull requests

7 participants
@xinbenlv @lightclient @sambacha @Pandapip1 @SamWilsn and others