-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add markdownlint workflow #1903
base: main
Are you sure you want to change the base?
Conversation
Note that MD041 is the replacement for the deprecated MD002 in https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md041---first-line-in-file-should-be-a-top-level-heading |
1ef4a55
to
60ded13
Compare
60ded13
to
d8a59a5
Compare
with: | ||
files: "." | ||
config_file: ".github/markdownlint.json" | ||
ignore_files: "analyzer-comments/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this doesn't work: https://github.com/marketplace/actions/markdownlint-cli
I tried
"analyzer-comments/*"
"analyzer-comments/**/*"
"analyzer-comments/**"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried "analyzer-comments"
or maybe "analyzer-comments/"
?
Looking at https://github.com/igorshubovych/markdownlint-cli, it seems like the globbing is used to reference specific files. But the CLI parameter also allows a directory to be ignored (allows file, directory or glob). The README for the link you have given mentions the same.
|
||
Have separate restricted queues for core and side exercises when importing solutions created in v1 or in Practice Mode. | ||
|
||
### [Website] Make side-exercise mentoring opt-in: | ||
## [Website] Make side-exercise mentoring opt-in: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colon at end of headings are not needed.
Same for other headings with colons or other punctuation (.?!:) at the end.
Not part of this change I know, but while you're editing the line...?
Just spotted a lot of these further down this change and the pedant grammarian in me is crying 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just recalled this is still in draft; I'll stop now!
No description provided.