-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
definition: max_line_length support #66
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@@ -16,6 +16,8 @@ const ( | |||
ConfigNameDefault = ".editorconfig" | |||
// UnsetValue is the value that unsets a preexisting variable. | |||
UnsetValue = "unset" | |||
// OffValue is the value that disables max_length (non-standard). | |||
OffValue = "off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we use unset
here too? What's the difference between toggling this off and unsetting it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unset
means restore default value, this is more like a false
.. but yeah...
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that off
is a bad naming... go-gitea/gitea#20694
Closes #45