Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing doesn't seem to work #9

Closed
mstruebing opened this issue Oct 4, 2018 · 2 comments
Closed

Installing doesn't seem to work #9

mstruebing opened this issue Oct 4, 2018 · 2 comments

Comments

@mstruebing
Copy link
Contributor

Hey, I wanted to make a small PR but I don't get it to work.

What I did:

go get -u github.com/editorconfig/editorconfig-core-go && \
go get go get -u gopkg.in/editorconfig/editorconfig-core-go.v1 && \
cd ~/go/github.com/editorconfig/editorconfig-core-go && \
make submodule && \
make installdeps

While executing make installdeps I get the following error:

$ make installdeps
go get -t ./...
# github.com/editorconfig/editorconfig-core-go/cmd/editorconfig
cmd/editorconfig/main.go:26:35: undefined: editorconfig.ConfigNameDefault
cmd/editorconfig/main.go:49:15: undefined: editorconfig.GetDefinitionForFilenameWithConfigname
make: *** [Makefile:12: installdeps] Error 2

Is this already known? How can I fix this? Or is it something with my specific setup/usage?

Thanks in advance for your help!
@10sr
Copy link
Member

10sr commented Oct 5, 2018

Sorry for inconvenience I've just released v1.3.0 .
It should be fixed after running go get -u gopkg.in/editorconfig/editorconfig-core-go.v1 again.
Thanks!

@mstruebing
Copy link
Contributor Author

Working now, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@10sr @mstruebing