update dependencies: editorconfig 0.12.9, pcre 10.44 #55
Conversation
|
Looks good to me. Just wondering if we still need to use appveyor? The builds from github action do the job nowadays. |
|
Just noticed that 0.12.9 has been released recently. Could you update the PR to 0.12.9? |
|
Compilation with 0.12.9 failed. Maybe due to updated cmake version of editorconfig-core. |
|
I agree we can remove appveyor. I believe we kept the appveyor configuration there for a grace period when we transited to github actions (although seems I can no longer find the conversation on that). Currently the appveyor test doesn't block merging any PRs. After you delete the appveyor conf file, I'll go ahread and shut down from the appveyor side. |
|
@ffes Removed appveyor.yml . |
|
Fixed the build of edc 0.12.9 by also using cmake version 3.16.3 in this plugin |
|
Once you merge I'll remove the integration. I feel it's better to make sure config in the master branch is synced with external CI settings :) |
|
I've merged it. The appveyor integration can be removed. And @chcg, thanks for your contribution. |
|
Integration removed 👌 |
Appveyor build fails because https://learn.microsoft.com/en-us/powershell/module/bitstransfer/start-bitstransfer?view=windowsserver2022-ps the -dynamic flag is just available on win11 and the corresponding server2022. Appveyor use https://learn.microsoft.com/en-us/powershell/module/bitstransfer/start-bitstransfer?view=windowsserver2019-ps ,see https://www.appveyor.com/docs/windows-images-software/ for Visual Studio 2022.