-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presets? #245
Comments
Can you explain a bit more? I don't understand your point on the |
So, instead of having a separate .eslintrc file, there are defined presets that can be leveraged via custom configuration objects in package.json, [like Gemfile, requirements.txt, etc., but for JS]. Example from airbnb: https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb package.json eslintConfig
{
"extends": "airbnb/base"
} |
👍 !! I have this |
☝️ Yep. That's exactly the problem I'm hoping to solve. |
It makes sense for me. This seems like a editorconfig-core-js specific issue.... Can we move the discussion there? |
It's not specific to JS. That was just an example. For presets to be actually usable, they need to be supported by all EditorConfig implementations, not just the JS one. It should work even if I for example use the EditorConfig Sublime plugin. I'm thinking: # .editorconfig
extends = path/to/folder/containing/editorconfig/file (Putting EditorConfig config into package.json should be a separate issue, on this issue tracker, as it also pertains to all implementation). |
@sindresorhus I'm all for consolidation. What about a global in |
@kevinSuttle That doesn't really solve my issue of having to put an |
Ah, I did not know that. I was thinking more of the global But I see your point about ensuring others follow suit and apply the same settings when the repo is distributed. |
I agree with @sindresorhus , it is exactly the reason we don't support a "global" configuration file. @sindresorhus If we have an "extends" or "include" instruction, is the |
@xuhdev Yes. See above #245 (comment) |
Yes, but that's a discussion for a different issue, but tl;dr; I have so many metafiles (.editorconfig, .gitignore, .gitattributes, etc) in my repos and I would like to reduce that number. Would be nice if I could define EditorConfig config in package.json instead of an .editorconfig file, since I almost always have a package.json file in my repos. Many other tools supports this. |
One useful usecase could be to commit a "company" wide editorconfig so it is not global for the computer but just the company repos. |
Is this a duplicate of #236? |
If @sindresorhus indeed reopened the issue for #245 (comment), then, yes, it looks like a duplicate of #236. |
Hearing nothing to the contrary, I am going to re-close this as duplicate to keep the discussion centralized in #236. |
Thinking about editorconfig/editorconfig-core-js#30, it would be handy to have a collection of presets.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: