Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify error handling for dns_get_record() #378

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Simplify error handling for dns_get_record() #378

wants to merge 1 commit into from

Conversation

aivchen
Copy link
Contributor

@aivchen aivchen commented Oct 15, 2023

No description provided.

@SebLevDev
Copy link

We have the same issue on running test with fake domain eg: example.com

TypeError: Egulias\EmailValidator\Validation\DNSRecords::__construct(): Argument #1 ($records) must be of type array, bool given, called in /www/vendor/egulias/email-validator/src/Validation/DNSGetRecordWrapper.php on line 24

/www/vendor/egulias/email-validator/src/Validation/DNSRecords.php:11
/www/vendor/egulias/email-validator/src/Validation/DNSGetRecordWrapper.php:24
/www/vendor/egulias/email-validator/src/Validation/DNSCheckValidation.php:148
/www/vendor/egulias/email-validator/src/Validation/DNSCheckValidation.php:130
/www/vendor/egulias/email-validator/src/Validation/DNSCheckValidation.php:97
/www/vendor/egulias/email-validator/src/Validation/MultipleValidationWithAnd.php:54
/www/vendor/egulias/email-validator/src/EmailValidator.php:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aivchen @SebLevDev