-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdg99 possibly not correctly disassembling vcha
/ vchar
instruction after FEND
?
#49
Comments
Or does
But on page 38 "9.29 FEND—End of Formatted Screen Write" it specifically says there is no operand:
And this |
vcha
/ vchar
instructionvcha
/ vchar
instruction after FEND
?
First of all, thanks alot for the bug report! It seems that the FOR argument is disassembled incorrectly. It's also a cool project you're doing! Regarding the FOR-END, this weird address argument does exist, and GROM cartridges containing this statement do execute it. Of course, my disassembly is also wrong. That's just my first glance, I'll have to look at it again later. Please note, however, I'm going on vacation later this week, and I don't know if I have time before that. |
I'll keep my eye out for your fix to see if it matched RetroGhidra's output. |
I think I called this wrong. As my disassembly gets more complete I understand things better. It now seems to me that the same opcode is used for By the way, I'm also having some trouble decoding the operand format for |
I've been working on my own GPL disassembler extension for the Ghidra reverse-engineering tool and found an anomaly disassembling a hello world example posted in the atariage forum for me to test on. I use xdg99 as a reference to check that my results match.
Here is xdg99's output:
And here is RetroGhidra's output:
Notice how at
602c
it looks like theFEND
instruction uses the three bytesfb 60 23
rather than justfb
as would be normal and the60
and23
bytes are blank to their right.After looking through the GPL docs I have I implemented the
6x
VCHA
instruction which seems correct for that position.The text was updated successfully, but these errors were encountered: