Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update globals dependency to ^15.0.0 #167

Closed
HummingMind opened this issue Jul 10, 2024 · 2 comments
Closed

Update globals dependency to ^15.0.0 #167

HummingMind opened this issue Jul 10, 2024 · 2 comments

Comments

@HummingMind
Copy link

Please update "globals" dependency to ^15.0.0

Thank you!

@nzakas
Copy link
Member

nzakas commented Jul 10, 2024

As mentioned in the README:

Note: This package is frozen except for critical bug fixes as ESLint moves to a new config system.

@nzakas nzakas closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
@piotr-cz
Copy link

piotr-cz commented Aug 28, 2024

There is a bug in the globals ^14.0.0 required by this package causing eslint to fail:

npx eslint

Oops! Something went wrong! :(

ESLint: 9.9.1

TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace.
    at [finalizeConfig] (xxx\node_modules\eslint\lib\config\flat-config-array.js:350:23)
    at FlatConfigArray.getConfigWithStatus (xxx\node_modules\@eslint\config-array\dist\cjs\index.cjs:1102:55)
    at FlatConfigArray.getConfig (xxx\node_modules\@eslint\config-array\dist\cjs\index.cjs:1120:15)
    at xxx\node_modules\eslint\lib\eslint\eslint-helpers.js:354:54
    at xxx\node_modules\eslint\lib\eslint\eslint-helpers.js:296:32
    at Object.isAppliedFilter (xxx\node_modules\@nodelib\fs.walk\out\readers\common.js:12:31)
    at AsyncReader._handleEntry (xxx\node_modules\@nodelib\fs.walk\out\readers\async.js:86:20)
    at xxx\node_modules\@nodelib\fs.walk\out\readers\async.js:65:22
    at callSuccessCallback (xxx\node_modules\@nodelib\fs.scandir\out\providers\async.js:103:5)
    at xxx\node_modules\@nodelib\fs.scandir\out\providers\async.js:29:13

It has been fixed in globals 15.0.0


Ah, apparently we have to install the globals package by manually, as stated here: eslint/eslint#18356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants