build: Publish to JSR and update release-please config #10
Conversation
release-please-config.json
Outdated
| @@ -1,18 +1,13 @@ | |||
| { | |||
| "bootstrap-sha": "505795a1312e90f1ce3b59b530622929bc38b4fe", | |||
| "last-release-sha": "48545ebe503d661af0562b240648253199758d9f", | |||
There was a problem hiding this comment.
Is this necessary? I believe we'd need to remove it after the next successful release, so if it isn't necessary it might be better not to add it.
There was a problem hiding this comment.
It's required when there's a change in the tag format, but since we're not doing that, this is unnecessary.
release-please-config.json
Outdated
| "bump-minor-pre-major": true, | ||
| "packages": { |
There was a problem hiding this comment.
Are you sure we can avoid having packages in the config? Per the docs, "the minimal content required defines at least one package".
https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#configfile
There was a problem hiding this comment.
Hmm, good question. I thought it wasn't necessary because all of the same properties are on the root level, but looking at the JSON Schema, it is indeed necessary. I'll revert this.
Prerequisites checklist
What is the purpose of this pull request?
Tweak the release-please behavior
What changes did you make? (Give an overview)
release-please-config.jsonbecause this isn't a monorepoRelated Issues
Is there anything you'd like reviewers to focus on?