Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Include info about VS Code and package-lock.json #11

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 12, 2024

Prerequisites checklist

What is the purpose of this pull request?

Update the README to be clearer

What changes did you make? (Give an overview)

  • Added mention that VS Code uses JSON-C
  • Added note that package-lock.json should normally be excluded from linting
  • Added note that package-lock.json uses empty keys and so should not be linted with no-empty-keys

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the documentation Improvements or additions to documentation label Jul 12, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 64c5af9 into main Jul 13, 2024
15 checks passed
@mdjermanovic mdjermanovic deleted the readme-update branch July 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants