Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 0.1.0 🚀 #2

Merged
merged 1 commit into from
Jul 9, 2024
Merged

chore: release 0.1.0 🚀 #2

merged 1 commit into from
Jul 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2024 •
edited
Loading

🤖 I have created a release beep boop

0.1.0 (2024-07-06)

Features

Bug Fixes

  • release-please (again) (#7) (5ef7c6c)
  • Set initial release version in release-please-config.json (#5) (64f4db5)

This PR was generated with Release Please. See documentation.

@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

mdjermanovic
mdjermanovic reviewed Jul 2, 2024
View reviewed changes
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@eslint/json",
"version": "0.0.1",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it didn't respect "bump-minor-pre-major": true option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's weird. I'll make another PR to reset the version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be because of the release-please action we're using.

In this repo, we're using google-github-actions/release-please-action@v4. In the rewrite repo, we're using GoogleCloudPlatform/release-please-action@v4. In other repos, e.g. espree, we're using google-github-actions/release-please-action@v3.

google-github-actions/release-please-action is deprecated in favor of googleapis/release-please-action@v4.

There seem to be a lot of different versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, had no idea all that was going on. I guess we should standardize on the new version.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--json branch from df13ac5 to 18f1bda Compare July 3, 2024 14:41
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@github-actions github-actions bot force-pushed the release-please--branches--main--components--json branch from 18f1bda to 6218fcc Compare July 4, 2024 20:53
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@mdjermanovic
Copy link
Member

Looks like Release-As: 0.1.0 in d8afca4 didn't work.

@nzakas
Copy link
Member

nzakas commented Jul 4, 2024

Looks like a known bug: googleapis/release-please-action#952

I think this will work: #5

@github-actions github-actions bot force-pushed the release-please--branches--main--components--json branch from 6218fcc to 7719bad Compare July 4, 2024 22:46
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@mdjermanovic
Copy link
Member

Nope again, it seems determined to release v1.0.0.

@mdjermanovic
Copy link
Member

Maybe #6 could help.

@mdjermanovic
Copy link
Member

Note that it didn't update jsr.json, so it's questionable whether our release-please-config.json is correct.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--json branch from 7719bad to 1703631 Compare July 5, 2024 06:33
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @github-actions[bot]!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@nzakas
Copy link
Member

nzakas commented Jul 5, 2024

This is bizarre. I have a similar setup in a person repo without any problems. Going to investigate now.

@nzakas
Copy link
Member

nzakas commented Jul 5, 2024

Maybe this will work: #7

@github-actions github-actions bot changed the title chore(main): release 1.0.0 chore: release {version} 🚀 Jul 5, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--json branch from 1703631 to 637a902 Compare July 5, 2024 16:56
@mdjermanovic
Copy link
Member

Maybe this will work: #7

It fixed the problem 🎉

Just it looks like the pattern should be updated a bit.

@github-actions github-actions bot changed the title chore: release {version} 🚀 chore: release 0.1.0 🚀 Jul 6, 2024
@github-actions github-actions bot force-pushed the release-please--branches--main--components--json branch from 637a902 to 60286d5 Compare July 6, 2024 09:45
mdjermanovic
mdjermanovic approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Just not sure if we should wait for eslint v9.7.0 (with eslint/eslint@6320732) before releasing this.

@nzakas
Copy link
Member

nzakas commented Jul 9, 2024

Because we aren't using any selectors, I think it's okay to release. I'm not going to make a formal announcement until next week anyway, but I'd like to ensure the release process works and get this integrated into eslint/eslint.

@nzakas nzakas merged commit 48545eb into main Jul 9, 2024
3 checks passed
@nzakas nzakas deleted the release-please--branches--main--components--json branch July 9, 2024 18:43
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jul 9, 2024

🤖 Created releases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas left review comments

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
autorelease: tagged chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdjermanovic @nzakas