-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): fix SEO docs headTags example #10014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
slorber
added
the
pr: documentation
This PR works on the website or other text documents in the repo.
label
Apr 4, 2024
slorber
changed the title
docs(seo): fix headTags config
docs(website): fix SEO docs headTags example
Apr 4, 2024
slorber
approved these changes
Apr 4, 2024
dumbbell
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Apr 9, 2024
The documentation for `headTags` was fixed in Docusaurus 3.2.1 (facebook/docusaurus#10014). The fact that they didn't work for us was not related to a problem in Docusuaurs (#facebook/docusaurus#9792), but an incorrect use on our side.
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: documentation
This PR works on the website or other text documents in the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Head tags should not be defined in theme config
Test Plan
Preview
Test links
Deploy preview:
https://deploy-preview-10014--docusaurus-2.netlify.app/docs/seo/
https://deploy-preview-10014--docusaurus-2.netlify.app/docs/3.2.0/seo/
https://deploy-preview-10014--docusaurus-2.netlify.app/docs/3.1.1/seo/
Related issues/PRs
#9991
fix #9792