Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN gateway connection should be authenticated #6110

Open
Kodylow opened this issue Sep 30, 2024 · 6 comments
Open

CLN gateway connection should be authenticated #6110

Kodylow opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
lightning Lightning module

Comments

@Kodylow
Copy link
Member

Kodylow commented Sep 30, 2024

Currently it's unauthenticated so the gateway can only run on the same local network

@m1sterc001guy m1sterc001guy added the lightning Lightning module label Oct 2, 2024
@Kodylow
Copy link
Member Author

Kodylow commented Oct 7, 2024

Might need to use certificates for this, would be ideal to just use straight password auth though.

@Kodylow Kodylow self-assigned this Oct 14, 2024
@vincenzopalazzo
Copy link
Contributor

@Kodylow you may want consider to use rune and commando, or move it to the grpc API of cln, but idk if it is a good move

@Kodylow
Copy link
Member Author

Kodylow commented Oct 21, 2024

  1. CoreLN currently broken on macOS. Bumped last week to 0.28.1, there's some incompatibility for mac specifically.
  2. Plugin is currently un-authed, removing grpc entirely and just using axum and we can use passwords + jwts. PR incoming @m1sterc001guy

@vincenzopalazzo
Copy link
Contributor

CoreLN currently broken on macOS.

Uh, really? what is the problem on macOS?

@m1sterc001guy
Copy link
Contributor

Uh, really? what is the problem on macOS?

We reverted the change that bumped CLN to 24.08.1, so it is no longer broken, but we won't be able to increase the version in the meantime,
#6193 (comment)

Let's tackle authentication after #6197

@vincenzopalazzo
Copy link
Contributor

We reverted the change that bumped CLN to 24.08.1, so it is no longer broken, but we won't be able to increase the version in the meantime,
#6193 (comment)

I see, sorry about that. I have no a osx env, so I could not reproduce it :/ otherwise I could try to patch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lightning Lightning module
Projects
None yet
Development

No branches or pull requests

3 participants